morazow commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1555171619
########## .github/workflows/template.python-wheels-ci.yml: ########## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Python Wheels CI + +on: + workflow_call: + +permissions: read-all + +jobs: + linux: + runs-on: ubuntu-latest + steps: + - name: Checkout the repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + persist-credentials: false + - name: Build wheels + run: | + cd flink-python + bash dev/build-wheels.sh + - name: Tar artifact + run: tar -cvf python-wheel.tar flink-python/dist Review Comment: Yes, good idea! ########## .github/workflows/template.python-wheels-ci.yml: ########## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Python Wheels CI + +on: + workflow_call: + +permissions: read-all + +jobs: + linux: + runs-on: ubuntu-latest + steps: + - name: Checkout the repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + persist-credentials: false + - name: Build wheels + run: | + cd flink-python + bash dev/build-wheels.sh + - name: Tar artifact + run: tar -cvf python-wheel.tar flink-python/dist + - name: Upload artifact + uses: actions/upload-artifact@v4 + with: + name: wheel_${{ runner.os }}_${{ github.sha }}_${{ github.run_number }} + path: python-wheel.tar + macos: + runs-on: macos-latest + steps: + - name: Checkout the repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + persist-credentials: false + - name: Install python Review Comment: Yes good idea, I took the same steps from Azure pipelines. But I agree having same Python version on both Linux/MacOs jobs is good idea. I will change workflow. I didn't check which version is installed in the Linux VM ########## .github/workflows/nightly.yml: ########## @@ -94,3 +94,6 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY }} s3_secret_key: ${{ secrets.IT_CASE_S3_SECRET_KEY }} + python-wheels: Review Comment: Yes, that should be fine, I would also prefer the inlined version. I wanted to keep the structure similar to other jobs, but python wheels are not used more than once. I will change it to the inlined version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
