XComp commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1540950575
########## .github/workflows/template.python-wheels-ci.yml: ########## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Python Wheels CI + +on: + workflow_call: + +permissions: read-all + +jobs: + linux: + runs-on: ubuntu-latest + steps: + - name: Checkout the repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + persist-credentials: false + - name: Build wheels + run: | + cd flink-python + bash dev/build-wheels.sh + - name: Tar artifact + run: tar -cvf python-wheel.tar flink-python/dist Review Comment: Would it make sense to also compress it here? Or is there a reason why compression is not enabled :thinking: ########## .github/workflows/template.python-wheels-ci.yml: ########## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Python Wheels CI + +on: + workflow_call: + +permissions: read-all + +jobs: + linux: + runs-on: ubuntu-latest + steps: + - name: Checkout the repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + persist-credentials: false + - name: Build wheels + run: | + cd flink-python + bash dev/build-wheels.sh + - name: Tar artifact + run: tar -cvf python-wheel.tar flink-python/dist + - name: Upload artifact + uses: actions/upload-artifact@v4 + with: + name: wheel_${{ runner.os }}_${{ github.sha }}_${{ github.run_number }} Review Comment: What are you referring to with "them"? The `name`, I guess? I'm wondering whether we should rely on what's provided in [apache/flink:.github/workflows/template.flink-ci.yml:106}(https://github.com/apache/flink/blob/master/.github/workflows/template.flink-ci.yml#L106) with the stringified workflow name. WDYT? ########## .github/workflows/nightly.yml: ########## @@ -94,3 +94,6 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY }} s3_secret_key: ${{ secrets.IT_CASE_S3_SECRET_KEY }} + python-wheels: Review Comment: I'm wondering whether we should just inline the two jobs. Adding them as a template makes the workflow appear on the left side of the workflow list in GitHub Actions (analogously to [the entry for the template.flink-ci.yml](https://github.com/apache/flink/actions/workflows/template.flink-ci.yml) without any additional utilization. One argument to keep the template workflow could be that we would be able to enable `workflow_dispatch` for the wheel generation. But I'm not aware of such a use-case. :thinking: WDYT? :thinking: ########## .github/workflows/template.python-wheels-ci.yml: ########## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Python Wheels CI + +on: + workflow_call: + +permissions: read-all + +jobs: + linux: + runs-on: ubuntu-latest + steps: + - name: Checkout the repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + persist-credentials: false + - name: Build wheels + run: | + cd flink-python + bash dev/build-wheels.sh + - name: Tar artifact + run: tar -cvf python-wheel.tar flink-python/dist + - name: Upload artifact + uses: actions/upload-artifact@v4 + with: + name: wheel_${{ runner.os }}_${{ github.sha }}_${{ github.run_number }} + path: python-wheel.tar + macos: + runs-on: macos-latest + steps: + - name: Checkout the repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + persist-credentials: false + - name: Install python Review Comment: I'm wondering whether we should also add the explicit python installation to Linux. To have both jobs use the same Python version. Have you checked that this is working on the GHA runners (i.e. is Python installed on Linux but not MacOS)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
