libenchao commented on code in PR #24567: URL: https://github.com/apache/flink/pull/24567#discussion_r1554798121
########## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdColumnUniquenessTest.scala: ########## @@ -193,26 +193,26 @@ class FlinkRelMdColumnUniquenessTest extends FlinkRelMdHandlerTestBase { @Test def testAreColumnsUniqueOnRank(): Unit = { - Array( - logicalRank, - flinkLogicalRank, - batchLocalRank, - batchGlobalRank, - streamRank, - logicalRankWithVariableRange, - flinkLogicalRankWithVariableRange, - streamRankWithVariableRange - ) - .foreach { - rank => - assertTrue(mq.areColumnsUnique(rank, ImmutableBitSet.of(0))) - (1 until rank.getRowType.getFieldCount).foreach { - idx => assertFalse(mq.areColumnsUnique(rank, ImmutableBitSet.of(idx))) - } - assertTrue(mq.areColumnsUnique(rank, ImmutableBitSet.of(0, 1))) - assertTrue(mq.areColumnsUnique(rank, ImmutableBitSet.of(0, 2))) - assertFalse(mq.areColumnsUnique(rank, ImmutableBitSet.of(1, 2))) - } +// Array( Review Comment: Why is this commented out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org