RubyChou commented on code in PR #24567:
URL: https://github.com/apache/flink/pull/24567#discussion_r1549314520
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/RankITCase.scala:
##########
@@ -656,18 +656,14 @@ class RankITCase(mode: StateBackendMode) extends
StreamingWithStateTestBase(mode
"(true,1,book,b,3,2)",
"(true,2,fruit,a,2,1)",
"(true,3,book,a,1,2)",
- "(true,3,book,a,1,2)",
Review Comment:
It's not expected, as the upsert key is wrong in the last commit, should be
partition by key and row number instead of partition by key and order by key.
The states are stored by upsert keys, therefore wrong upsert keys will cause
wrong result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
