1996fanrui commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1538587604
##########
flink-autoscaler/pom.xml:
##########
@@ -57,6 +57,18 @@ under the License.
<groupId>org.quartz-scheduler</groupId>
<artifactId>quartz</artifactId>
<version>${quartz.version}</version>
+ <exclusions>
+ <exclusion>
+ <artifactId>HikariCP-java7</artifactId>
+ <groupId>com.zaxxer</groupId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>com.zaxxer</groupId>
+ <artifactId>HikariCP</artifactId>
+ <version>${hikari.version}</version>
Review Comment:
> I'll be testing MySQL and PostgreSQL later, and I'm still tweaking it.
So far, flink-kubernetes-operator doesn't support Jdbc state store and event
handler. But autoscaler uses quartz, this comment isn't related to MySQL and
PostgreSQL.
This comment means whether flink-kubernetes-operator with autoscaler works
well when we introduce the other version for `HikariCP`.
Also, standalone-autoscaler will use the Jdbc state store and event handler,
it's needed to test them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
