1996fanrui commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1538509399
##########
flink-autoscaler/pom.xml:
##########
@@ -57,6 +57,18 @@ under the License.
<groupId>org.quartz-scheduler</groupId>
<artifactId>quartz</artifactId>
<version>${quartz.version}</version>
+ <exclusions>
+ <exclusion>
+ <artifactId>HikariCP-java7</artifactId>
+ <groupId>com.zaxxer</groupId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>com.zaxxer</groupId>
+ <artifactId>HikariCP</artifactId>
+ <version>${hikari.version}</version>
Review Comment:
Are you sure this dependency works with quartz? Did you test
flink-kubernetes-operator with autoscaler?
##########
flink-autoscaler-standalone/pom.xml:
##########
@@ -133,6 +133,12 @@ under the License.
<version>${log4j.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.zaxxer</groupId>
+ <artifactId>HikariCP</artifactId>
+ <version>${hikari.version}</version>
+ </dependency>
Review Comment:
If `flink-autoscaler` depends on `HikariCP`, and
`flink-autoscaler-standalone` depends on `flink-autoscaler`.
Why does `flink-autoscaler-standalone` still need to depends on `HikariCP`?
IIUC, `flink-autoscaler-standalone` already depends on `HikariCP` silently.
Please correct me if my understanding is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
