fredia commented on code in PR #24402:
URL: https://github.com/apache/flink/pull/24402#discussion_r1524524431
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java:
##########
@@ -219,6 +219,18 @@ public TaskStateSnapshot retrieveLocalState(long
checkpointID) {
snapshot = loadTaskStateSnapshot(checkpointID);
}
+ // Even if local recovery is disabled, it is still necessary to load
the TaskStateSnapshot
Review Comment:
nit: I think `localRecoveryConfig.isLocalRecoveryEnabled()` can be checked
first, which can avoid acquiring for the lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
