ljz2051 commented on code in PR #24402:
URL: https://github.com/apache/flink/pull/24402#discussion_r1512793149
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalBackupAndRecoveryDirectoryProvider.java:
##########
@@ -48,7 +48,7 @@
*
* <p>
*/
-public interface LocalRecoveryDirectoryProvider extends Serializable {
+public interface LocalBackupAndRecoveryDirectoryProvider extends Serializable {
Review Comment:
This class is utilized by both LocalRecovery and LocalBackup. If we were to
name it "LocalBackupDirectoryProvider," it would seem strange to create a
LocalBackupDirectoryProvider when LocalBackup is disabled (but LocalRecovery is
enabled). And naming it "LocalRecoveryDirectoryProvider" face the same dilemma.
How about we name it "LocalSnapshotDirectoryProvider"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
