XComp commented on code in PR #24237:
URL: https://github.com/apache/flink/pull/24237#discussion_r1472915149
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##########
@@ -634,17 +628,23 @@ public ExecutingStateBuilder setLastRescale(Instant
lastRescale) {
private Executing build(MockExecutingContext ctx) {
executionGraph.transitionToRunning();
- return new Executing(
- executionGraph,
- getExecutionGraphHandler(executionGraph,
ctx.getMainThreadExecutor()),
- operatorCoordinatorHandler,
- log,
- ctx,
- ClassLoader.getSystemClassLoader(),
- new ArrayList<>(),
- scalingIntervalMin,
- scalingIntervalMax,
- lastRescale);
+ try {
+ return new Executing(
+ executionGraph,
+ getExecutionGraphHandler(executionGraph,
ctx.getMainThreadExecutor()),
+ operatorCoordinatorHandler,
+ log,
+ ctx,
+ ClassLoader.getSystemClassLoader(),
+ new ArrayList<>(),
+ scalingIntervalMin,
+ scalingIntervalMax,
+ lastRescale);
+ } finally {
+ Preconditions.checkState(
Review Comment:
true, I didn't see that one because it's not failing (at least on my
machine) when running all `ExecutingTest` test methods. Is this the case for
you as well? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
