echauchot commented on code in PR #24237:
URL: https://github.com/apache/flink/pull/24237#discussion_r1477979041
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##########
@@ -88,7 +88,7 @@ class Executing extends StateWithExecutionGraph implements
ResourceListener {
deploy();
// check if new resources have come available in the meantime
- rescaleWhenCooldownPeriodIsOver();
+ context.runIfState(this, this::rescaleWhenCooldownPeriodIsOver,
Duration.ZERO);
Review Comment:
I see: it was missing the condition that the current state is the Executing
state when executing the rescale (and transitioning to Restarting state). In
other words, the transition to Executing is finished before any other
transition. Now with the assert in the builder
`testExecutingChecksForNewResourcesWhenBeingCreated` will fail if a transition
happens during Executing creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
