1996fanrui commented on code in PR #759:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/759#discussion_r1461443852
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java:
##########
@@ -160,14 +160,23 @@ private void runScalingLogic(Context ctx,
AutoscalerFlinkMetrics autoscalerMetri
var collectedMetrics = metricsCollector.updateMetrics(ctx, stateStore);
var jobTopology = collectedMetrics.getJobTopology();
+ var now = clock.instant();
Review Comment:
Hi @afedulov ,
We are using `now` as the `endTime` of ScalingRecord. The
`kubernetes.operator.reconcile.interval` is 1 min by default and `scaling` is
called in each reconcile.
So, the restartTime will be greater than `1 min` even if the scaling is very
quick.
I'm not sure should we get the endTime from the `JobUpdateTs`? Currently,
`stabilization.interval` checks the `JobUpdateTs`.
Looking forward to your feedback, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
