1996fanrui commented on code in PR #759:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/759#discussion_r1470625450
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##########
@@ -104,17 +106,18 @@ public CollectedMetricHistory updateMetrics(
var jobDetailsInfo =
getJobDetailsInfo(ctx,
conf.get(AutoScalerOptions.FLINK_CLIENT_TIMEOUT));
- var jobUpdateTs = getJobUpdateTs(jobDetailsInfo);
+ var jobSwitchToRunningTs = getJobSwitchToRunningTs(jobDetailsInfo);
Review Comment:
> Can we keep the old name jobUpdateTs? Or rename to jobRunningTs?
Renaming it to `jobRunningTs`.
> This change is a bit unrelated to the original issue in this PR.
That's why I split this PR into 2 commits.
- The first commit is refactor, it gets the jobRunningTs from
JobStatus.RUNNING instead of max timestamp.
- The second commit is core change of the original issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
