davidradl commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1438684232
##########
pom.xml:
##########
@@ -63,6 +63,9 @@ under the License.
<flink.parent.artifactId>flink-connector-jdbc-parent</flink.parent.artifactId>
<flink.forkCountITCase>1</flink.forkCountITCase>
+ <!-- These 2 properties should be removed together with upgrade of
flink-connector-parent to 1.1.x -->
+ <flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m
-XX:+IgnoreUnrecognizedVMOptions
${surefire.module.config}</flink.surefire.baseArgLine>
+ <surefire.module.config/>
Review Comment:
yes there was a merge conflict I will sort this out
##########
.github/workflows/weekly.yml:
##########
@@ -34,6 +34,11 @@ jobs:
branch: main
}, {
flink: 1.18-SNAPSHOT,
+ jdk: '8, 11, 17',
+ branch: main
+ }, {
+ flink: 1.19-SNAPSHOT,
+ jdk: '8, 11, 17, 21',
Review Comment:
yes there was a merge conflict I will sort this out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
