snuyanzin commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1434090293
##########
.github/workflows/push_pr.yml:
##########
@@ -25,7 +25,14 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
+ flink: [ 1.16-SNAPSHOT, 1.17-SNAPSHOT ]
+ jdk: [ '8, 11' ]
+ include:
+ - flink: 1.18-SNAPSHOT
+ jdk: '8, 11, 17'
+ - flink: 1.19-SNAPSHOT
+ jdk: '8, 11, 17, 21'
Review Comment:
Why is is this a part of the PR?
It is already in main
I guess you need to rebase
##########
.github/workflows/weekly.yml:
##########
@@ -34,6 +34,11 @@ jobs:
branch: main
}, {
flink: 1.18-SNAPSHOT,
+ jdk: '8, 11, 17',
+ branch: main
+ }, {
+ flink: 1.19-SNAPSHOT,
+ jdk: '8, 11, 17, 21',
Review Comment:
Why is is this a part of the PR?
It is already in main
I guess you need to rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
