TanYuxin-tyx commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1435920016
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/NettyConnectionWriterImpl.java:
##########
@@ -30,24 +30,33 @@ public class NettyConnectionWriterImpl implements
NettyConnectionWriter {
private final NettyConnectionId connectionId;
- private final BufferAvailabilityListener availabilityListener;
+ private Runnable availabilityListener;
+ public NettyConnectionWriterImpl(NettyPayloadManager nettyPayloadManager) {
+ this.nettyPayloadManager = nettyPayloadManager;
+ this.connectionId = NettyConnectionId.newId();
+ }
+
+ @VisibleForTesting
Review Comment:
Do we need this `VisibleForTesting`? Could we test the logic by the existing
public/protected methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
