yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433743541
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/PartitionRequestClient.java:
##########
@@ -62,9 +62,11 @@ void requestSubpartition(
* Notifies the id of segment required from one remote input channel.
*
* @param inputChannel The remote input channel who requires segment.
+ * @param subpartitionIndex The id of the corresponding subpartition.
Review Comment:
According to offline discussions, we would use id in the following situations
- Tiered Hybrid Shuffle
- Parameters with type `TieredStorageSubpartitionId`
- Used as keys in maps
And use index or idx in the following situations
- Other shuffle types and the common modules shared among shuffles
- Parameters with type `int`
- Used as indexes in arrays
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
