twalthr commented on code in PR #23948:
URL: https://github.com/apache/flink/pull/23948#discussion_r1430298273
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/PlannerQueryOperation.java:
##########
@@ -72,6 +75,13 @@ public String asSummaryString() {
"PlannerNode", Collections.emptyMap(), getChildren(),
Operation::asSummaryString);
}
+ @Override
+ public String asSerializableString() {
+ final RelToSqlConverter relToSqlConverter = new
RelToSqlConverter(AnsiSqlDialect.DEFAULT);
Review Comment:
Not sure if `AnsiSqlDialect.DEFAULT` is a good idea. This might have
implications on serialization of quotes or some other tiny little details.
Since `PlannerQueryOperation` comes right out of the planner we can also pass
some context into it. Don't we have some RelToSqlConverter or Flink dialect
somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
