dawidwys commented on code in PR #23948: URL: https://github.com/apache/flink/pull/23948#discussion_r1432520652
########## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala: ########## @@ -1646,6 +1650,28 @@ object TableTestUtil { planner.translateToRel(modifyOperation) } + def toQuotedSqlString(relNode: RelNode, tEnv: TableEnvironment): String = { Review Comment: It's called only in the `TableTestBase#addTableWithWatermark`. On a second thought, I think it's better to throw an exception in this case. 1. We don't need it here, in this `TestBase` 2. LogicalWatermarkAssigner cannot be converted back to a `SqlNode` anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org