dawidwys commented on code in PR #23811: URL: https://github.com/apache/flink/pull/23811#discussion_r1413862636
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/CallSyntaxUtils.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.functions; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.expressions.FieldReferenceExpression; +import org.apache.flink.table.expressions.ResolvedExpression; +import org.apache.flink.table.expressions.ValueLiteralExpression; + +/** Utility functions that can be used for writing {@link CallSyntax}. */ +@Internal +class CallSyntaxUtils { + + /** + * Converts the given {@link ResolvedExpression} into a SQL string. Wraps the string with + * parenthesis if the expression is not a leaf expression such as e.g. {@link + * ValueLiteralExpression} or {@link FieldReferenceExpression}. + */ + static String asSerializableOperand(ResolvedExpression expression) { Review Comment: I added that primarily for `BINARY`/`UNARY` operators such as e.g. `+` or `AND` where the precedence matter. In all other cases it should work just fine. That's why I don't call it everywhere cause otherwise we'd have a highly unreadable SQL full of parenthesis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
