dawidwys commented on code in PR #23811:
URL: https://github.com/apache/flink/pull/23811#discussion_r1407735613
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java:
##########
@@ -219,6 +219,11 @@ public String asSummaryString() {
return stringifyValue(value);
}
+ @Override
+ public String asSerializableString() {
+ return stringifyValue(value);
Review Comment:
I am sure, it is not. My plan was to work on literal serialization next.
Enabling e2e tests (in `BuiltinFunctionTestBase`) shows it actually makes sense
to reverse the order and start with `ValueLiteralExpression` if we want to
enable e2e tests along with this PR, I need to handle literals first.
FYI: not only arrays are the issue, but at least also temporals (TIMESTAMP,
DATE, ...), and `null` value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
