grzegorz8 commented on PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#issuecomment-1821252252
> Hi @grzegorz8, thanks for your contribution. I left some comments > > but should be this PR on https://github.com/apache/flink-connector-elasticsearch ?? I just thought flink-connector-jdbc is the most suitable place - I merely add a JDBC dialect. This repo already contains lots of test utils that are used for elastic dialect as well. Alternatively, we can add a new module `flink-jdbc-dialect` (or similar name) to `flink-connector-elasticsearch` but I'm not sure it is the best idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
