grzegorz8 commented on code in PR #67:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1420783379


##########
flink-connector-jdbc/pom.xml:
##########
@@ -38,10 +38,12 @@ under the License.
                <scala.binary.version>2.12</scala.binary.version>
                <scala-library.version>2.12.7</scala-library.version>
                <assertj.version>3.23.1</assertj.version>
+               <jackson.version>2.15.2</jackson.version>
                <postgres.version>42.5.1</postgres.version>
                <oracle.version>21.8.0.0</oracle.version>
                <trino.version>418</trino.version>
                <byte-buddy.version>1.12.10</byte-buddy.version>
+               <elasticsearch.version>8.11.1</elasticsearch.version>

Review Comment:
   @MartijnVisser Hi! What should be done to ensure if adding this dependency 
(even as "provided") is allowed? The same question for enabling Elastic trial 
for testing purposes.
   Should I create a ticket somewhere? Write to elastic_lice...@elastic.co? 
What do you suggest? Or should we already close the PR and corresponding ticket 
due to incompatible license?
   
   The license is not listed on Category X: 
https://www.apache.org/legal/resolved.html#category-x (nor in any other). 
Assuming Elastic License is "Category X", I think we are still safe, since we 
do not violate the following rules mentioned in the document: _"They may not be 
distributed"_ and _"You may rely on them when they support an optional 
feature"_.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to