MartijnVisser commented on code in PR #67:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1399140949


##########
flink-connector-jdbc/pom.xml:
##########
@@ -38,10 +38,12 @@ under the License.
                <scala.binary.version>2.12</scala.binary.version>
                <scala-library.version>2.12.7</scala-library.version>
                <assertj.version>3.23.1</assertj.version>
+               <jackson.version>2.15.2</jackson.version>
                <postgres.version>42.5.1</postgres.version>
                <oracle.version>21.8.0.0</oracle.version>
                <trino.version>418</trino.version>
                <byte-buddy.version>1.12.10</byte-buddy.version>
+               <elasticsearch.version>8.11.1</elasticsearch.version>

Review Comment:
   We need to be really careful about what's included here, since the 
Elasticsearch dependency that's being references isn't an Apache-compatible 
license
   
   > Code that is licensed solely under the Elastic License 2.0 is found only 
in the x-pack folder.
   https://github.com/elastic/elasticsearch/blob/main/LICENSE.txt



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to