SmirAlex commented on PR #23521: URL: https://github.com/apache/flink/pull/23521#issuecomment-1812051645
Hi @Sxnan! Sorry, I understand that I'm not a reviewer, but it happened that I was testing functionality from this MR recently, and I found a bug (in my opinion). It concerns the logic of `RecordAttributesValve`. I my test there was very little backlog data at source + it had parallelism 4 (actually, any value > 1 suits the case). Due to very short backlog phase, time interval between sending RecordAttributes(isBacklog=true) and RecordAttributes(isBacklog=false) was also very short. In addition, due to the high parallelism one source subtask could send RecordAttributes(isBacklog=false) even before RecordAttributes(isBacklog=true) of another subtask. As a result, race condition have occurred in `RecordAttributesValve#inputRecordAttributes`. `backlogChannelsCnt` was incrementing and decrementing simultaneously, which led to not reaching 'numInputChannels' at all, so no `RecordAttributes` was emitted from `RecordAttributesValve`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
