JunRuiLee commented on code in PR #23408:
URL: https://github.com/apache/flink/pull/23408#discussion_r1375838262
##########
flink-clients/src/main/java/org/apache/flink/client/program/StreamContextEnvironment.java:
##########
@@ -303,6 +303,7 @@ private void checkMainConfiguration(Configuration
clusterConfigMap, List<String>
private void checkCheckpointConfig(Configuration clusterConfigMap,
List<String> errors) {
CheckpointConfig expectedCheckpointConfig = new CheckpointConfig();
expectedCheckpointConfig.configure(clusterConfigMap);
+ configureCheckpointStorage(clusterConfigMap, expectedCheckpointConfig);
Review Comment:
Using state.checkpoint-storage for comparison is not entirely accurate, as
it only checks if the Storage class name is the same. The root cause of this
issue is the lack of robustness in the current mechanism for checking the
checkpoint storage. Therefore, I prefer not to address this issue in this PR.
Additionally, we are planning to deprecate the storage setter interface soon
and migrate all configuration options into the configuration. I would prefer to
update the checkpoint storage checking mechanism after the migration is
completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
