zhuzhurk commented on code in PR #23408:
URL: https://github.com/apache/flink/pull/23408#discussion_r1374369701
##########
flink-clients/src/main/java/org/apache/flink/client/program/StreamContextEnvironment.java:
##########
@@ -303,6 +303,7 @@ private void checkMainConfiguration(Configuration
clusterConfigMap, List<String>
private void checkCheckpointConfig(Configuration clusterConfigMap,
List<String> errors) {
CheckpointConfig expectedCheckpointConfig = new CheckpointConfig();
expectedCheckpointConfig.configure(clusterConfigMap);
+ configureCheckpointStorage(clusterConfigMap, expectedCheckpointConfig);
Review Comment:
The created `CheckpointStorage` may not be equal to the actual
`CheckpointStorage` if the `equals()` method is not implemented, in which case
it will compare if they are the same java instance.
How about to avoid doing this, but instead set `filesystem` to
`state.checkpoint-storage` when `CheckpointConfig#setCheckpointStorage(...)` is
invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
