[ 
https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639114#comment-15639114
 ] 

ASF GitHub Bot commented on FLINK-4260:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2758#discussion_r86661487
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/util/CollectionDataSets.java
 ---
    @@ -54,6 +51,18 @@
      */
     public class CollectionDataSets {
     
    +   public static DataSet<Tuple1<String>> 
getTupleDateSet(ExecutionEnvironment env) {
    +
    +           List<Tuple1<String>> data = new ArrayList<>();
    +           data.add(new Tuple1<String>("%leo*"));
    +           data.add(new Tuple1<String>(("%deng*")));
    +           data.add(new Tuple1<String>("%hello*"));
    --- End diff --
    
    I think we should add some negative test data (without `%` and `*`).
    
    And I would like not to touch other modules if possible, it's better to 
move the specific test data to the specific test class.  


> Allow SQL's LIKE ESCAPE
> -----------------------
>
>                 Key: FLINK-4260
>                 URL: https://issues.apache.org/jira/browse/FLINK-4260
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Timo Walther
>            Assignee: Leo Deng
>            Priority: Minor
>
> Currently, the SQL API does not support specifying an ESCAPE character in a 
> LIKE expression. The SIMILAR TO should also support that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to