[
https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639113#comment-15639113
]
ASF GitHub Bot commented on FLINK-4260:
---------------------------------------
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2758#discussion_r86661415
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/sql/SqlITCase.java
---
@@ -118,4 +119,39 @@ public void testJoin() throws Exception {
String expected = "Hi,Hallo\n" + "Hello,Hallo Welt\n" + "Hello
world,Hallo Welt\n";
compareResultAsText(results, expected);
}
+
+
+ @Test
+ public void testLikeWithEscapeFromDataSet() throws Exception {
--- End diff --
We try to keep the number of integration tests for the Table API to a
minimum to not exceed Travis' build time threshold of 2 hours. I think we do
not need the IT cases, the `ScalarFunctionsTest` should cover all cases.
You can add new tests to `ScalarFunctionsTest` called `testLikeWithEscape`,
`testSimilarWithEscape` just like what `testLike` did.
> Allow SQL's LIKE ESCAPE
> -----------------------
>
> Key: FLINK-4260
> URL: https://issues.apache.org/jira/browse/FLINK-4260
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.1.0
> Reporter: Timo Walther
> Assignee: Leo Deng
> Priority: Minor
>
> Currently, the SQL API does not support specifying an ESCAPE character in a
> LIKE expression. The SIMILAR TO should also support that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
