[ 
https://issues.apache.org/jira/browse/FLINK-33000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771803#comment-17771803
 ] 

Matthias Pohl commented on FLINK-33000:
---------------------------------------

[~fsk119] are you taking care of the backports as well?

> SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using 
> a ThreadFactory
> ---------------------------------------------------------------------------------------------
>
>                 Key: FLINK-33000
>                 URL: https://issues.apache.org/jira/browse/FLINK-33000
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Gateway, Tests
>    Affects Versions: 1.16.2, 1.18.0, 1.17.1, 1.19.0
>            Reporter: Matthias Pohl
>            Assignee: Jiabao Sun
>            Priority: Major
>              Labels: pull-request-available, starter
>
> {{SqlGatewayServiceITCase}} uses a {{ExecutorThreadFactory}} for its 
> asynchronous operations. Instead, one should use {{TestExecutorExtension}} to 
> ensure proper cleanup of threads.
> We might also want to remove the {{AbstractTestBase}} parent class because 
> that uses JUnit4 whereas {{SqlGatewayServiceITCase}} is already based on 
> JUnit5



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to