[ https://issues.apache.org/jira/browse/FLINK-33000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769470#comment-17769470 ]
Shengkai Fang commented on FLINK-33000: --------------------------------------- Merged into master: de6c66ea805760f1550ae1fa348630edd9f17256 73717520cc63df8bd08fd008ac004659b210cfd1 de6c66ea805760f1550ae1fa348630edd9f17256 TODO: Merged into release 1.18/1.17/1.16 > SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using > a ThreadFactory > --------------------------------------------------------------------------------------------- > > Key: FLINK-33000 > URL: https://issues.apache.org/jira/browse/FLINK-33000 > Project: Flink > Issue Type: Bug > Components: Table SQL / Gateway, Tests > Affects Versions: 1.16.2, 1.18.0, 1.17.1, 1.19.0 > Reporter: Matthias Pohl > Priority: Major > Labels: pull-request-available, starter > > {{SqlGatewayServiceITCase}} uses a {{ExecutorThreadFactory}} for its > asynchronous operations. Instead, one should use {{TestExecutorExtension}} to > ensure proper cleanup of threads. > We might also want to remove the {{AbstractTestBase}} parent class because > that uses JUnit4 whereas {{SqlGatewayServiceITCase}} is already based on > JUnit5 -- This message was sent by Atlassian Jira (v8.20.10#820010)