z3d1k commented on code in PR #102:
URL:
https://github.com/apache/flink-connector-aws/pull/102#discussion_r1343894856
##########
flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/table/RowDataKinesisDeserializationSchema.java:
##########
@@ -118,6 +118,11 @@ public RowData deserialize(
throws IOException {
RowData physicalRow = physicalDeserializer.deserialize(recordValue);
+ // If message can not be deserialized by physicalDeserializer - return
null to skip record
+ if (physicalRow == null) {
+ return null;
+ }
Review Comment:
This is part of `DeserializationSchema` interface behaviour:
> @return The deserialized message as an object (null if the message cannot
be deserialized).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
