dannycranmer commented on code in PR #102:
URL:
https://github.com/apache/flink-connector-aws/pull/102#discussion_r1343856160
##########
flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/table/RowDataKinesisDeserializationSchema.java:
##########
@@ -118,6 +118,11 @@ public RowData deserialize(
throws IOException {
RowData physicalRow = physicalDeserializer.deserialize(recordValue);
+ // If message can not be deserialized by physicalDeserializer - return
null to skip record
+ if (physicalRow == null) {
+ return null;
+ }
Review Comment:
Assume this only happens if the json deserializer is configured to ignore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
