[
https://issues.apache.org/jira/browse/FLINK-33051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766655#comment-17766655
]
Panagiotis Garefalakis commented on FLINK-33051:
------------------------------------------------
Hey [~wangm92] – thanks for the writeup!
I dont think merging the two interfaces in one will help, as the
scheduler/State classes will still have to implement 2 methods (one with
Throwble, and another with Throwable and labels), making the code less readable.
Replacing the GlobalFailureHandler with LabeledGlobalFailureHandler should in
principle be doable but we might have to push the labeling logic earlier in the
process and will end up changing most of the existing logic.
I believe we need to take a step back here and weight our options – WDYT?
> Unify the GlobalFailureHandler and LabeledGlobalFailureHandler interface
> ------------------------------------------------------------------------
>
> Key: FLINK-33051
> URL: https://issues.apache.org/jira/browse/FLINK-33051
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
> Reporter: Panagiotis Garefalakis
> Assignee: Matt Wang
> Priority: Minor
>
> FLIP-304 introduced `LabeledGlobalFailureHandler` interface that is an
> extension of `GlobalFailureHandler` interface. The later can thus be removed
> in the future to avoid the existence of interfaces with duplicate functions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
