Fanoid commented on code in PR #252:
URL: https://github.com/apache/flink-ml/pull/252#discussion_r1301008956
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/evaluation/binaryclassification/BinaryClassificationEvaluator.java:
##########
@@ -520,13 +354,16 @@ private static long[]
reduceBinarySummary(List<BinarySummary> values, int taskId
*/
private static void updateBinarySummary(
BinarySummary statistics, Tuple3<Double, Boolean, Double>
evalElement) {
- if (evalElement.f1) {
- statistics.curPositive++;
+ boolean isPos = evalElement.f1;
+ double weight = evalElement.f2;
+ double score = evalElement.f0;
+ if (isPos) {
Review Comment:
I think it's harmless to declare variable here. And it provides more
readability compared to guessing meanings from the tuple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
