weibozhao commented on code in PR #252:
URL: https://github.com/apache/flink-ml/pull/252#discussion_r1299709302
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/evaluation/binaryclassification/BinaryClassificationEvaluator.java:
##########
@@ -673,25 +510,26 @@ public static class BinarySummary implements Serializable
{
public Integer taskId;
// maximum score in this partition
public double maxScore;
- // real positives in this partition
- public long curPositive;
- // real negatives in this partition
- public long curNegative;
+ // sum of weights of positives in this partition
+ public double sumWeightPos;
+ // sum of weights of negatives in this partition
+ public double sumWeightNeg;
public BinarySummary() {}
- public BinarySummary(Integer taskId, double maxScore, long
curPositive, long curNegative) {
+ public BinarySummary(
+ Integer taskId, double maxScore, double sumWeightPos, double
sumWeightNeg) {
this.taskId = taskId;
this.maxScore = maxScore;
- this.curPositive = curPositive;
- this.curNegative = curNegative;
+ this.sumWeightPos = sumWeightPos;
+ this.sumWeightNeg = sumWeightNeg;
}
}
/** The evaluation metrics for binary classification. */
public static class BinaryMetrics {
/* The count of samples. */
- public long count;
+ public double count;
Review Comment:
This double variable 'count' is not a count yet. The name here is not
suitable. Maybe 'weightSum' or 'accValue' is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
