Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1299304252
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerTest.java:
##########
@@ -61,12 +54,16 @@ public void channelEnumerator() throws Exception {
File path = id.getPathFile();
- assertTrue("Channel IDs must name an absolute path.",
path.isAbsolute());
- assertFalse("Channel IDs must name a file, not a directory.",
path.isDirectory());
+ assertThat(path.isAbsolute())
+ .withFailMessage("Channel IDs must name an absolute
path.")
+ .isTrue();
+ assertThat(path.isDirectory())
+ .withFailMessage("Channel IDs must name a file, not a
directory.")
+ .isFalse();
Review Comment:
The test will fail if we directly assert that path is file, because the file
does not exist here.
So I created that file before asserting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
