1996fanrui commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295872872


##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/FileChannelManagerImplTest.java:
##########
@@ -89,28 +90,29 @@ public void testFairness() throws Exception {
             threads[i].join();
         }
 
-        assertEquals(counter1.get(), counter2.get());
+        assertThat(counter2.get()).isEqualTo(counter1.get());

Review Comment:
   Sorry, I got it now.
   
   How about `assertThat(counter2).hasValue(counter1.get());`? 
   
   nit: This is a really nitty remark. Feel free to ignore it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to