reswqa commented on code in PR #23179:
URL: https://github.com/apache/flink/pull/23179#discussion_r1295350783


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSubpartitionFileReaderImpl.java:
##########
@@ -329,13 +327,15 @@ private Optional<BufferIndexOrError> 
checkAndGetFirstBufferIndexOrError(
         return Optional.ofNullable(peek);
     }
 
-    private void increaseBacklog(Buffer buffer) {
+    @GuardedBy("lock")
+    private void tryIncreaseBacklog(Buffer buffer) {
         if (buffer.isBuffer()) {
             backlog.getAndIncrement();
         }
     }
 
-    private void decreaseBacklog(Buffer buffer) {
+    @GuardedBy("lock")

Review Comment:
   Should be removed as `backlog` is no longer guarded by `lock`.



##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSubpartitionFileReaderImpl.java:
##########
@@ -329,13 +327,15 @@ private Optional<BufferIndexOrError> 
checkAndGetFirstBufferIndexOrError(
         return Optional.ofNullable(peek);
     }
 
-    private void increaseBacklog(Buffer buffer) {
+    @GuardedBy("lock")

Review Comment:
   Should be removed as `backlog` is no longer guarded by `lock` anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to