WencongLiu commented on code in PR #23179: URL: https://github.com/apache/flink/pull/23179#discussion_r1292974002
########## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/NettyPayloadQueue.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition.hybrid.tiered.netty; + +import java.util.LinkedList; +import java.util.Queue; + +/** + * The {@link NettyPayloadQueue} is the queue to contain different types of {@link NettyPayload} and + * calculate the backlog number. + */ +public class NettyPayloadQueue { Review Comment: The interface `java.util.Queue` extends an interface `java.util.Collection`. The interface `java.util.Collection` also extends another interface `java.lang.Iterable`. There're many methods in these three interfaces that `NettyPayloadQueue` doesn't need in fact. I'd prefer it not to implement any interface. WDYT? 🤔 ########## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/NettyPayloadQueue.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition.hybrid.tiered.netty; + +import java.util.LinkedList; +import java.util.Queue; + +/** + * The {@link NettyPayloadQueue} is the queue to contain different types of {@link NettyPayload} and + * calculate the backlog number. + */ +public class NettyPayloadQueue { Review Comment: The interface `java.util.Queue` extends an interface `java.util.Collection`. The interface `java.util.Collection` also extends another interface `java.lang.Iterable`. There're many methods in these three interfaces that `NettyPayloadQueue` doesn't need in fact. I'd prefer it not to implement any interface. WDYT? 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
