pgaref commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1198148957
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/ExecutionFailureHandler.java:
##########
@@ -51,22 +58,39 @@ public class ExecutionFailureHandler {
/** Number of all restarts happened since this job is submitted. */
private long numberOfRestarts;
+ private final Context taskFailureCtx;
+ private final Context globalFailureCtx;
+ private final Collection<FailureEnricher> failureEnrichers;
+ private final ComponentMainThreadExecutor mainThreadExecutor;
+
/**
* Creates the handler to deal with task failures.
*
* @param schedulingTopology contains the topology info for failover
* @param failoverStrategy helps to decide tasks to restart on task
failures
* @param restartBackoffTimeStrategy helps to decide whether to restart
failed tasks and the
* restarting delay
+ * @param mainThreadExecutor the main thread executor of the job master
+ * @param failureEnrichers a collection of {@link FailureEnricher} that
enrich failures
+ * @param taskFailureCtx Task failure Context used by FailureEnrichers
+ * @param globalFailureCtx Global failure Context used by FailureEnrichers
*/
public ExecutionFailureHandler(
final SchedulingTopology schedulingTopology,
final FailoverStrategy failoverStrategy,
- final RestartBackoffTimeStrategy restartBackoffTimeStrategy) {
+ final RestartBackoffTimeStrategy restartBackoffTimeStrategy,
+ final ComponentMainThreadExecutor mainThreadExecutor,
+ final Collection<FailureEnricher> failureEnrichers,
+ final Context taskFailureCtx,
+ final Context globalFailureCtx) {
this.schedulingTopology = checkNotNull(schedulingTopology);
this.failoverStrategy = checkNotNull(failoverStrategy);
this.restartBackoffTimeStrategy =
checkNotNull(restartBackoffTimeStrategy);
+ this.mainThreadExecutor = checkNotNull(mainThreadExecutor);
+ this.failureEnrichers = checkNotNull(failureEnrichers);
+ this.taskFailureCtx = taskFailureCtx;
Review Comment:
Sure, update FLINK-32114 with your comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
