pgaref commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1195892521
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/exceptionhistory/ExceptionHistoryEntry.java:
##########
@@ -63,21 +66,27 @@ public static ExceptionHistoryEntry create(AccessExecution
failedExecution, Stri
return new ExceptionHistoryEntry(
failure.getException(),
failure.getTimestamp(),
+ failure.getLabelsFuture(),
taskName,
failedExecution.getAssignedResourceLocation());
}
/** Creates an {@code ExceptionHistoryEntry} that is not based on an
{@code Execution}. */
public static ExceptionHistoryEntry createGlobal(Throwable cause) {
Review Comment:
This is actually tracked by the follow-up FLINK-31892 so I believe we are
good here (all other methods include labels)
https://github.com/apache/flink/pull/22587/commits/99f41cfb94b20162cce28f7e9ec5662afe385689#diff-96bec50fecaaa9b559479b5f90e508fb6185a9a1886f295f0dbe3d0567794e38R74-R75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
