wanglijie95 commented on code in PR #31:
URL:
https://github.com/apache/flink-connector-jdbc/pull/31#discussion_r1168131549
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java:
##########
@@ -53,7 +56,7 @@ private JdbcXaSinkFunctionState(
* @return immutable collection of prepared XA transactions to {@link
* javax.transaction.xa.XAResource#commit commit}.
*/
- public Collection<CheckpointAndXid> getPrepared() {
+ protected Collection<CheckpointAndXid> getPrepared() {
Review Comment:
This change is not needed now.
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java:
##########
@@ -28,6 +30,7 @@
/** Thread-safe (assuming immutable {@link Xid} implementation). */
@ThreadSafe
+@PublicEvolving
Review Comment:
The `JdbcXaSinkFunctionState` should not mark as `PublicEvolving` due to
`XaSinkStateHandler` is `@Internal` now. We should change it to `@Internal`
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/options/JdbcConnectionOptions.java:
##########
@@ -32,15 +31,15 @@
/** Options for the JDBC connector. */
@Internal
-public class JdbcConnectorOptions extends JdbcConnectionOptions {
+public class JdbcConnectionOptions extends
org.apache.flink.connector.jdbc.JdbcConnectionOptions {
Review Comment:
It would be better to change this class to another name, not same as the
existing `JdbcConnectionOptions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
