MartijnVisser commented on code in PR #16:
URL:
https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162816269
##########
.github/workflows/release.yml:
##########
@@ -24,7 +24,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16.1, 1.17.0]
+ flink: [1.17.0]
Review Comment:
I actually think you need to add `.github/workflows/push_pr.yml` to set the
Flink version either to a matrix (with Flink 1.17.1 and potentially Flink
1.18-SNAPSHOT), or at least that version should be updated to 1.17.1 :)
##########
.github/workflows/release.yml:
##########
@@ -24,7 +24,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16.1, 1.17.0]
+ flink: [1.17.0]
Review Comment:
I actually think you need to update `.github/workflows/push_pr.yml` to set
the Flink version either to a matrix (with Flink 1.17.1 and potentially Flink
1.18-SNAPSHOT), or at least that version should be updated to 1.17.1 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
