MartijnVisser commented on code in PR #16:
URL:
https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1159391470
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
> The thing i would like to clarify whether it's ok to drop support for 1.16
while it's still maintained in main flink repo?
> @MartijnVisser may be you have more info about this ?
It's up to the maintainers to decide how you want to support two versions of
Flink.
I was actually expecting that there was an Opensearch v3.0 branch, given
that it has been released. Perhaps it makes sense to still create that.
I think if you would do that, you could follow the first example from
https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development#ExternalizedConnectordevelopment-Examples
That would make it possible to drop support for 1.16 in this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
