SteNicholas commented on code in PR #584:
URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1138642067
##########
flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java:
##########
@@ -82,6 +82,20 @@ public class FlinkConnectorOptions {
+ "By default, if this option is not
defined, the planner will derive the parallelism "
+ "for each statement individually by also
considering the global configuration.");
+ public static final ConfigOption<Boolean> INFER_SCAN_PARALLELISM =
+ ConfigOptions.key("scan.infer-parallelism")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "If it is false, parallelism of source are set by
scan.parallelism. "
+ + "If it is true, source parallelism is
inferred according to splits number (batch mode) or bucket number(streaming
mode).");
+
+ public static final ConfigOption<Integer> INFER_SCAN_PARALLELISM_MAX =
+ ConfigOptions.key("scan.infer-parallelism.max")
Review Comment:
@zhangjun0x01, the implementation of the Hive reference makes sense because
hive connector couldn't control the split number, but table store could control
splits number and bucket number. I don't think this solution could refer to
Hive for the different situation between table table and hive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
