xintongsong commented on code in PR #22119:
URL: https://github.com/apache/flink/pull/22119#discussion_r1138313793
##########
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java:
##########
@@ -853,6 +855,9 @@ public static void main(final String[] args) {
"",
""); // no prefix for the YARN session
+ final CommandLine commandLine =
CliFrontendParser.parse(cli.allOptions, args, true);
+ DynamicPropertiesUtil.encodeDynamicProperties(commandLine,
flinkConfiguration);
Review Comment:
I noticed that dynamic properties are applied in
`FlinkYarnSessionCli#toConfiguration`, which is called in
`FlinkYarnSessionCli#run`. That implies `FlinkYarnSessionCli` expects the
configuration being passed in does not include dynamic properties.
Obviously, applying the dynamic properties in
`FlinkYarnSessionCli#toConfiguration` is too late for the security
configurations. I think we have 2 options:
1. Apply the dynamic properties earlier. We would need to carefully check
the codes between the original and new applying position, making sure applying
the properties earlier would not cause problems. (That's what I meant by "not
entirely sure about the impact".)
2. Or we can keep the applying of dynamic properties as is, and make a copy
of the configuration that only affects the security settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
