felixzh2020 commented on code in PR #22119:
URL: https://github.com/apache/flink/pull/22119#discussion_r1138083328


##########
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java:
##########
@@ -853,6 +855,9 @@ public static void main(final String[] args) {
                             "",
                             ""); // no prefix for the YARN session
 
+            final CommandLine commandLine = 
CliFrontendParser.parse(cli.allOptions, args, true);
+            DynamicPropertiesUtil.encodeDynamicProperties(commandLine, 
flinkConfiguration);

Review Comment:
   Thanks your review. But i think that clone is not right. Because 
yarn-session.sh is also support to use "-D <property=value>" to overwrite 
flink.conf.yaml. The cmd parameter priority is must higher than the 
configuration file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to