Aitozi commented on code in PR #21522:
URL: https://github.com/apache/flink/pull/21522#discussion_r1137115733
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java:
##########
@@ -703,7 +704,7 @@ private CompactReader.Factory<RowData>
createCompactReaderFactory(
jobConf,
catalogTable,
hiveVersion,
- (RowType) tableSchema.toRowDataType().getLogicalType(),
+ (RowType) resolvedSchema.toSinkRowDataType().getLogicalType(),
Review Comment:
Why ? I think in sink it should deal with the `Column::isPersisted` data
type. So the compact reader factory should use `toSinkRowDataType `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
