Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137091668
########## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveLookupTableSource.java: ########## @@ -258,8 +256,12 @@ private TableFunction<RowData> getLookupFunction(int[] keys) { jobConf, hiveVersion, tablePath, - getTableSchema().getFieldDataTypes(), - getTableSchema().getFieldNames(), + DataType.getFieldDataTypes( Review Comment: I think we should exclude the computed column here. So I use `DataType.getFieldDataTypes( catalogTable.getResolvedSchema().toPhysicalRowDataType()) .toArray(new DataType[0])` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org