Aitozi commented on code in PR #21522:
URL: https://github.com/apache/flink/pull/21522#discussion_r1134279553


##########
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogMetadataTestBase.java:
##########
@@ -60,4 +65,50 @@ public void testCreateFunctionCaseInsensitive() throws 
Exception {
     protected CatalogFunction createPythonFunction() {
         return new CatalogFunctionImpl("test.func1", FunctionLanguage.PYTHON);
     }
+
+    /**
+     * Convert the {@link ResolvedSchema} to a {@link Schema}, and also 
convert the {@link
+     * ResolvedExpression} back to its Unresolved state. This will enable 
direct comparison of the
+     * schema.
+     */
+    public static Schema fromResolvedSchema(ResolvedSchema resolvedSchema) {

Review Comment:
   The `ResolvedExpression` in resolvedSchema is different from the Expression 
in the string format. For example, `SqlCallExpression`'s format will have '[]' 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to